On 17 April 2015 17:52:09 BST, Andrew Bresticker <abrestic@xxxxxxxxxxxx> wrote: >Hi James, > >On Fri, Apr 17, 2015 at 2:44 AM, James Hogan <james.hogan@xxxxxxxxxx> >wrote: >> Implement the mips_cdmm_phys_base() platform callback to provide a >> default Common Device Memory Map (CDMM) physical base address for the >> Pistachio SoC. This allows the CDMM in each VPE to be configured and >> probed for devices, such as the Fast Debug Channel (FDC). >> >> The physical address chosen is just below the default CPC address, >which >> appears to also be unallocated. >> >> The FDC IRQ is also usable on Pistachio, and is routed through the >GIC, >> so implement the get_c0_fdc_int() platform callback using >> gic_get_c0_fdc_int(), so the FDC driver doesn't have to fall back to >> polling. >> >> Signed-off-by: James Hogan <james.hogan@xxxxxxxxxx> > >Reviewed-by: Andrew Bresticker <abrestic@xxxxxxxxxxxx> Thanks for the reviews Andrew. Cheers James