On Sun, Mar 29, 2015 at 10:54:10AM +0800, Huacai Chen wrote: > arch/mips/loongson/common/pci.c | 6 ++ > drivers/platform/mips/Makefile | 3 + > drivers/platform/mips/acpi_init.c | 150 +++++++++++++++++++++++++++++++++++++ Applied - but: This isn't even a proper driver but rather a collection of subroutines. I wonder this has to reside in drivers/platform/mips, not in drivers/acpi/ or even in the Loongson arch code? > diff --git a/drivers/platform/mips/Makefile b/drivers/platform/mips/Makefile > index 8dfd039..522c8e1 100644 > --- a/drivers/platform/mips/Makefile > +++ b/drivers/platform/mips/Makefile > @@ -1 +1,4 @@ > +ifdef CONFIG_CPU_LOONGSON3 > +obj-y += acpi_init.o > obj-$(CONFIG_CPU_HWMON) += cpu_hwmon.o > +endif This is where the yelling starts. A Makefile that doesn't define any obj-* or lib-* variables such as this one if CONFIG_CPU_LOONGSON3 is undefined, will break the build. In other words, this hasn't been tested on even a single other platform. I've fixed this but it's normally up to the submitter to ensure this sort of thing doesn't happen. Ralf
