OK, I'll improve my code as soon as possible. BTW, if these two patches are OK, please apply them. :) http://patchwork.linux-mips.org/patch/8825/ http://patchwork.linux-mips.org/patch/8826/ On Thu, Mar 26, 2015 at 8:36 PM, Ralf Baechle <ralf@xxxxxxxxxxxxxx> wrote: > On Fri, Mar 13, 2015 at 10:28:26AM +0800, Huacai Chen wrote: > >> This add south-bridge (SB700/SB710/SB800 chipset) ACPI platform driver >> for Loongson-3. This will be used by EC (Embedded Controller, used by >> laptops) driver and STR (Suspend To RAM). > > No Kconfig options? In commit 6/8 the Kconfig help text promises: > > +++ b/drivers/platform/mips/Kconfig > @@ -0,0 +1,26 @@ > +# > +# MIPS Platform Specific Drivers > +# > + > +menuconfig MIPS_PLATFORM_DEVICES > + bool "MIPS Platform Specific Device Drivers" > + default y > + help > + Say Y here to get to see options for device drivers of various > + MIPS platforms, including vendor-specific netbook/laptop/desktop > + extension and hardware monitor drivers. This option itself does > + not add any kernel code. > > Then this patch adds loongson-specific code that will be built for all > MIPS platforms. And it will fail to build for non-loongson platforms. > > Ralf >
