Re: [PATCH] pci: octeon: Remove udelay() causing huge IRQ latency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 18 Mar 2015, Alexander Sverdlin wrote:

> udelay() in PCI/PCIe read/write callbacks cause 30ms IRQ latency on Octeon
> platforms because these operations are called from PCI_OP_READ() and
> PCI_OP_WRITE() under raw_spin_lock_irqsave().
> 
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx>

I have no idea about the octeon platform, but how do you deal with the 
fact that is stated by the comment you are removing? I.e.

	/* Some PCI cards require delays when accessing config space. */

Is that not the case any more for some reason? If not, it really needs to 
be explained in the changelog.

-- 
Jiri Kosina
SUSE Labs





[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux