On Fri, Mar 06, 2015 at 09:45:16AM -0800, Greg Kroah-Hartman wrote:
> On Fri, Mar 06, 2015 at 08:22:49AM -0800, Guenter Roeck wrote:
> > On Thu, Mar 05, 2015 at 10:30:34PM -0800, Greg Kroah-Hartman wrote:
> > > On Thu, Mar 05, 2015 at 04:08:44PM +0000, James Hogan wrote:
> > > > [ Upstream commit 3ce465e04bfd8de9956d515d6e9587faac3375dc ]
> > > >
> > > > Export the _save_fp asm function used by the lose_fpu(1) macro to GPL
> > > > modules so that KVM can make use of it when it is built as a module.
> > > >
> > > > This fixes the following build error when CONFIG_KVM=m due to commit
> > > > f798217dfd03 ("KVM: MIPS: Don't leak FPU/DSP to guest"):
> > > >
> > > > ERROR: "_save_fp" [arch/mips/kvm/kvm.ko] undefined!
> > > >
> > > > Signed-off-by: James Hogan <james.hogan@xxxxxxxxxx>
> > > > Fixes: f798217dfd03 (KVM: MIPS: Don't leak FPU/DSP to guest)
> > > > Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> > > > Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> > > > Cc: Paul Burton <paul.burton@xxxxxxxxxx>
> > > > Cc: Gleb Natapov <gleb@xxxxxxxxxx>
> > > > Cc: kvm@xxxxxxxxxxxxxxx
> > > > Cc: linux-mips@xxxxxxxxxxxxxx
> > > > Cc: <stable@xxxxxxxxxxxxxxx> # 3.10...3.15
> > > > Patchwork: https://patchwork.linux-mips.org/patch/9260/
> > > > Signed-off-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> > > > [james.hogan@xxxxxxxxxx: Only export when CPU_R4K_FPU=y prior to v3.16,
> > > > so as not to break the Octeon build which excludes FPU support. KVM
> > > > depends on MIPS32r2 anyway.]
> > > > Signed-off-by: James Hogan <james.hogan@xxxxxxxxxx>
> > > > ---
> > > > Appologies for the previous cavium_octeon_defconfig link breakage.
> > > > Octeon has the symbol since 3.16, but not before. This backport should
> > > > do the trick for stable 3.10, 3.12, and 3.14. Build tested with
> > > > cavium_octeon_defconfig and malta_kvm_defconfig on those stable
> > > > branches.
> > > > ---
> > > > arch/mips/kernel/mips_ksyms.c | 8 ++++++++
> > > > 1 file changed, 8 insertions(+)
> > >
> > > Now fixed up, thanks.
> > >
> > My auto-builders still fail to build cavium_octeon_defconfig for 3.10 and 3.14,
> > and as far as I can see they picked up no changes. Did you push the changes into
> > the stable queue repository ?
>
> I didn't push it publically, didn't have access to my 2-factor key so
> couldn't do it. Should be there now, sorry about that.
>
Confirmed, all is good now.
Thanks,
Guenter
