It seems your patch is better, please ignore mine.
Huacai
On Tue, Mar 3, 2015 at 3:22 PM, Markos Chandras
<markos.chandras@xxxxxxxxxx> wrote:
> On Tue, Mar 03, 2015 at 09:49:08AM +0800, Huacai Chen wrote:
>> Commit 46490b572544f (MIPS: kernel: elf: Improve the overall ABI and
>> FPU mode checks) assumes mips_set_personality_fp() is only needed in
>> CONFIG_MIPS_O32_FP64_SUPPORT case. However, this assumption is wrong,
>> because O32 binaries always need the correct thread flags to set
>> FR/FRE, whether CONFIG_MIPS_O32_FP64_SUPPORT is configured or not.
>>
>> Signed-off-by: Huacai Chen <chenhc@xxxxxxxxxx>
>> ---
>> arch/mips/kernel/elf.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/mips/kernel/elf.c b/arch/mips/kernel/elf.c
>> index d2c09f6..cec5bc3 100644
>> --- a/arch/mips/kernel/elf.c
>> +++ b/arch/mips/kernel/elf.c
>> @@ -245,7 +245,7 @@ void mips_set_personality_fp(struct arch_elf_state *state)
>> * not be worried about N32/N64 binaries.
>> */
>>
>> - if (!config_enabled(CONFIG_MIPS_O32_FP64_SUPPORT))
>> + if (!config_enabled(CONFIG_32BIT) && !config_enabled(CONFIG_MIPS32_O32))
>> return;
>>
>> switch (state->overall_fp_mode) {
>> --
>> 1.7.7.3
>>
>>
>>
>>
> Hi,
>
> I have already posted a patch for this problem. Could you try that instead?
>
> http://patchwork.linux-mips.org/patch/9344/
>
> --
> markos
>
