On Mon, Mar 2, 2015 at 1:26 PM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, 26 Feb 2015 19:07:09 -0800 Kees Cook <keescook@xxxxxxxxxxxx> wrote: > >> This separates ET_DYN ASLR from mmap ASLR, as already done on s390. The >> various architectures that are already randomizing mmap (arm, arm64, mips, >> powerpc, s390, and x86), have their various forms of arch_mmap_rnd() >> made available via the new CONFIG_ARCH_HAS_ELF_RANDOMIZE. For these >> architectures, arch_randomize_brk() is collapsed as well. >> >> This is an alternative to the solutions in: >> https://lkml.org/lkml/2015/2/23/442 > > "504 Gateway Time-out" > > Hector's original patch had very useful descriptions of the bug, why it > occurred, how it was exploited it and how the patch fixes it. > > Your changelogs contain none of this and can be summarized as "randomly > churn code around for no apparent reason". > > Wanna try again? I guess the [0/5] and [4/5] changelogs are the ones > to fix. Ah, yes, absolutely. I will resend. -Kees -- Kees Cook Chrome OS Security
