Re: [PATCH] MIPS: KVM: Fix trace event to save PC directly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 24, 2015 at 11:46:20AM +0000, James Hogan wrote:
> Currently the guest exit trace event saves the VCPU pointer to the
> structure, and the guest PC is retrieved by dereferencing it when the
> event is printed rather than directly from the trace record. This isn't
> safe as the printing may occur long afterwards, after the PC has changed
> and potentially after the VCPU has been freed. Usually this results in
> the same (wrong) PC being printed for multiple trace events. It also
> isn't portable as userland has no way to access the VCPU data structure
> when interpreting the trace record itself.
> 
> Lets save the actual PC in the structure so that the correct value is
> accessible later.

Applied, thanks.






[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux