On Fri, Feb 27, 2015 at 5:36 PM, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > Hi Kees, > > On Fri, 27 Feb 2015 16:52:29 -0800 Kees Cook <keescook@xxxxxxxxxxxx> wrote: >> >> diff --git a/arch/arm/include/asm/seccomp.h b/arch/arm/include/asm/seccomp.h >> index 52b156b341f5..66ca6a30bf5c 100644 >> --- a/arch/arm/include/asm/seccomp.h >> +++ b/arch/arm/include/asm/seccomp.h >> @@ -1,11 +1 @@ >> -#ifndef _ASM_ARM_SECCOMP_H >> -#define _ASM_ARM_SECCOMP_H >> - >> -#include <linux/unistd.h> >> - >> -#define __NR_seccomp_read __NR_read >> -#define __NR_seccomp_write __NR_write >> -#define __NR_seccomp_exit __NR_exit >> -#define __NR_seccomp_sigreturn __NR_rt_sigreturn >> - >> -#endif /* _ASM_ARM_SECCOMP_H */ >> +#include <asm-generic/seccomp.h> > > I think that these cases (where you replace the file by a stub that > just include <asm-generic/seccomp.h>) can be replaced by removing the > file completely and adding > > generic-y = seccomp.h > > to <ARCH>/include/asm/Kbuild Ah-ha! I thought total removal was possible, but I lacked the Kbuild piece. There are a lot of arch/ headers that are just the one line. Maybe I should send a another patch to clean up those? -Kees -- Kees Cook Chrome OS Security
