Re: [PATCH] MIPS: mark prom_free_prom_memory() everywhere with __init

[David Daney <ddaney.cavm@xxxxxxxxx>]

On 02/25/2015 03:31 PM, Aaro Koskinen wrote:
> Mark prom_free_prom_memory with() everywhere with __init.
>
> On OCTEON the function is non-trivial and we can potentially even
> save some memory.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx>

OCTEON part:

Acked-by: David Daney <david.daney@xxxxxxxxxx>

> ---
>   arch/mips/cavium-octeon/setup.c  | 2 +-
>   arch/mips/lantiq/prom.c          | 2 +-
>   arch/mips/mti-sead3/sead3-init.c | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/setup.c b/arch/mips/cavium-octeon/setup.c
> index a42110e..d0fa0bc 100644
> --- a/arch/mips/cavium-octeon/setup.c
> +++ b/arch/mips/cavium-octeon/setup.c
> @@ -1043,7 +1043,7 @@ int prom_putchar(char c)
>   }
>   EXPORT_SYMBOL(prom_putchar);
>
> -void prom_free_prom_memory(void)
> +void __init prom_free_prom_memory(void)
>   {
>   	if (CAVIUM_OCTEON_DCACHE_PREFETCH_WAR) {
>   		/* Check for presence of Core-14449 fix.  */
> diff --git a/arch/mips/lantiq/prom.c b/arch/mips/lantiq/prom.c
> index 39ab3e7..0db099e 100644
> --- a/arch/mips/lantiq/prom.c
> +++ b/arch/mips/lantiq/prom.c
> @@ -41,7 +41,7 @@ int ltq_soc_type(void)
>   	return soc_info.type;
>   }
>
> -void prom_free_prom_memory(void)
> +void __init prom_free_prom_memory(void)
>   {
>   }
>
> diff --git a/arch/mips/mti-sead3/sead3-init.c b/arch/mips/mti-sead3/sead3-init.c
> index bfbd17b..3572ea3 100644
> --- a/arch/mips/mti-sead3/sead3-init.c
> +++ b/arch/mips/mti-sead3/sead3-init.c
> @@ -147,6 +147,6 @@ void __init prom_init(void)
>   #endif
>   }
>
> -void prom_free_prom_memory(void)
> +void __init prom_free_prom_memory(void)
>   {
>   }