Re: [PATCH RFC v2 67/70] MIPS: kernel: process: Do not allow FR=0 on MIPS R6

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/29/2015 11:13 PM, Paul Burton wrote:
> On Fri, Jan 16, 2015 at 10:49:46AM +0000, Markos Chandras wrote:
>> A prctl() call to set FR=0 for MIPS R6 should not be allowed
>> since FR=1 is the only option for R6 cores.
>>
>> Cc: Paul Burton <paul.burton@xxxxxxxxxx>
>> Cc: Matthew Fortune <matthew.fortune@xxxxxxxxxx>
>> Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx>
>> ---
>>  arch/mips/include/asm/fpu.h | 3 ++-
>>  arch/mips/kernel/process.c  | 4 ++++
>>  2 files changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/include/asm/fpu.h b/arch/mips/include/asm/fpu.h
>> index 994d21939676..b96d9d327626 100644
>> --- a/arch/mips/include/asm/fpu.h
>> +++ b/arch/mips/include/asm/fpu.h
>> @@ -68,7 +68,8 @@ static inline int __enable_fpu(enum fpu_mode mode)
>>  		goto fr_common;
>>  
>>  	case FPU_64BIT:
>> -#if !(defined(CONFIG_CPU_MIPS32_R2) || defined(CONFIG_64BIT))
>> +#if !(defined(CONFIG_CPU_MIPS32_R2) || defined(CONFIG_CPU_MIPS32_R6) \
>> +      || defined(CONFIG_64BIT))
> 
> Hi Markos,
> 
> This change really seems like a separate one, since it has nothing to do
> with the prctl or disallowing FR=1, but rather with allowing FR=1 on r6.
> 
> Thanks,
>     Paul

Thanks I will move it to a separate patch

-- 
markos





[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux