On Wed, Jan 21, 2015 at 09:59:59AM -0800, David Daney wrote: > On 01/21/2015 07:27 AM, Markos Chandras wrote: > >The "addi" instruction will trap on overflows which is not something > >we need in this code, so we replace that with "addiu". > > > >Link: http://www.linux-mips.org/archives/linux-mips/2015-01/msg00430.html > >Cc: Maciej W. Rozycki <macro@xxxxxxxxxxxxxx> > >Cc: <stable@xxxxxxxxxxxxxxx> # v3.15+ > >Cc: Paul Burton <paul.burton@xxxxxxxxxx> > >Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx> > > Acked-by: David Daney <david.daney@xxxxxxxxxx> > > Same comment about the stable thing. Is it needed for anything other than > follow-on MIPS r6 Patches? In both this & the MSA asmmacro.h cases, the additions should never cause overflow. So I agree, backporting to stable seems like overkill. Paul > > >--- > >Moving this out of the R6 patchset as requested by Maciej > >--- > > arch/mips/kernel/cps-vec.S | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > [...]