Re: [PATCH RFC v2 31/70] MIPS: kernel: traps: Add MIPS R6 related definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 16 Jan 2015, Markos Chandras wrote:

> diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
> index 461653ea28c8..81cface72bb0 100644
> --- a/arch/mips/kernel/traps.c
> +++ b/arch/mips/kernel/traps.c
> @@ -1649,7 +1649,7 @@ asmlinkage void cache_parity_error(void)
>  	printk("Decoded c0_cacheerr: %s cache fault in %s reference.\n",
>  	       reg_val & (1<<30) ? "secondary" : "primary",
>  	       reg_val & (1<<31) ? "data" : "insn");
> -	if (cpu_has_mips_r2 &&
> +	if ((cpu_has_mips_r2 || cpu_has_mips_r6) &&

 Same observation about the `cpu_has_mips_r2_r6' macro as in the other 
e-mail.  Likewise throughout this patch.  I won't repeat it for any 
further occurences in the remaining patches, please assume this 
automatically and revise the changes yourself.

>  	    ((current_cpu_data.processor_id & 0xff0000) == PRID_COMP_MIPS)) {

 Hmm, this could and should use `PRID_COMP_MASK' rather than hardcoded 
0xff0000.  Similarly elsewhere down this patch.  That'd be a separate 
cleanup.

  Maciej




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux