Re: [PATCH RFC v2 10/70] MIPS: asm: asmmacro: Drop unused 'reg' argument on MIPSR2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 16 Jan 2015, Markos Chandras wrote:

> The local_irq_{enable, disable} macros do not use the reg argument
> so drop it.
> 
> Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx>
> ---
>  arch/mips/include/asm/asmmacro.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/include/asm/asmmacro.h b/arch/mips/include/asm/asmmacro.h
> index 6caf8766b80f..90f69c334a75 100644
> --- a/arch/mips/include/asm/asmmacro.h
> +++ b/arch/mips/include/asm/asmmacro.h
> @@ -20,12 +20,12 @@
>  #endif
>  
>  #ifdef CONFIG_CPU_MIPSR2
> -	.macro	local_irq_enable reg=t0
> +	.macro	local_irq_enable
>  	ei
>  	irq_enable_hazard
>  	.endm
>  
> -	.macro	local_irq_disable reg=t0
> +	.macro	local_irq_disable
>  	di
>  	irq_disable_hazard
>  	.endm

 Their !CONFIG_CPU_MIPSR2 counterparts do however.  Have you checked with 
GAS that it is acceptable to pass an extra argument to a macro that 
doesn't expect one?

  Maciej




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux