Re: [PATCH RFC v2 12/70] MIPS: asm: asmmacro: Replace add instructions with "addui"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 19 Jan 2015, Markos Chandras wrote:

> sorry i might be missing something but why do you think this is an
> important bug fix that should go into 3.19? the way i read the code it
> seems that it can't go wrong at the moment.

 We shouldn't be using trapping instructions for address calculation.  
These macros have been wrong since the beginning, the MSA instructions 
they correspond to do not trigger an exception on an integer overflow in 
address calculation (none of the MIPS instruction does).

  Maciej




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux