> The previous implementation did not cover all possible FPU combinations > and it silently allowed ABI incompatible objects to be loaded with the > wrong ABI. For example, the previous logic would set the FP_64 ABI as > the matching ABI for an FP_XX object combined with an FP_64A object. > This was wrong, and the matching ABI should have been FP_64A. > The previous logic is now replaced with a new one which determines > the appropriate FPU mode to be used rather than the FP ABI. This has > the advantage that the entire logic is much simpler since it is the FPU > mode we are interested in rather than the FP ABI resulting to code > simplifications. Markos, Can you confirm that the o32 abiflags testsuite has been run on a 64-bit kernel? I know that the o32 testsuite has run on a 32-bit kernel and the n64 testsuite has run on a 64-bit kernel. It is certainly worth checking given the fixes that are being made to 3.19. Is it worth updating the CONFIG_MIPS_O32_FP64_SUPPORT option to no longer be experimental and also default on? This option could then guard the new logic from this patch as a safety measure. Once the code has been proven I'd suggest removing the option and making the code unconditional. Maciej: The comments you made here http://patchwork.linux-mips.org/patch/8932/ should be addressed by this patch. Thanks, Matthew
