Re: [PATCH] MIPS: 74K/1074K: Fix typo in erratum workaround.

[Leonid Yegoshin <Leonid.Yegoshin@xxxxxxxxxx>]

On 01/06/2015 02:39 AM, Tony Wu wrote:
> In commit 9213ad (MIPS: 74K/1074K: Correct erratum workaround.),
> MIPS_CACHE_VTAG should go to icache.flags.
>
> Signed-off-by: Tony Wu <tung7970@xxxxxxxxx>
> Cc: Maciej W. Rozycki <macro@xxxxxxxxxxxxxx>
> Cc: Steven J. Hill <Steven.Hill@xxxxxxxxxx>
> Cc: Leonid Yegoshin <Leonid.Yegoshin@xxxxxxxxxx>
>
> diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c
> index dd261df..deebd0b 100644
> --- a/arch/mips/mm/c-r4k.c
> +++ b/arch/mips/mm/c-r4k.c
> @@ -902,13 +902,13 @@ static inline void alias_74k_erratum(struct cpuinfo_mips *c)
>   	switch (imp) {
>   	case PRID_IMP_74K:
>   		if (rev <= PRID_REV_ENCODE_332(2, 4, 0))
> -			c->dcache.flags |= MIPS_CACHE_VTAG;
> +			c->icache.flags |= MIPS_CACHE_VTAG;
>   		if (rev == PRID_REV_ENCODE_332(2, 4, 0))
>   			write_c0_config6(read_c0_config6() | MIPS_CONF6_SYND);
>   		break;
>   	case PRID_IMP_1074K:
>   		if (rev <= PRID_REV_ENCODE_332(1, 1, 0)) {
> -			c->dcache.flags |= MIPS_CACHE_VTAG;
> +			c->icache.flags |= MIPS_CACHE_VTAG;
>   			write_c0_config6(read_c0_config6() | MIPS_CONF6_SYND);
>   		}
>   		break;
It is not a typo, it is a special case and an original patch should 
follow the patch

http://patchwork.linux-mips.org/patch/8459/

which has a use of 'cpu_has_vtag_dcache'

- Leonid.