On Wed, Dec 17, 2014 at 06:39:01PM -0800, Brian Norris wrote: > Fixes sparse warnings: > > arch/mips/jz4740/irq.c:63:6: warning: symbol 'jz4740_irq_suspend' was not declared. Should it be static? > arch/mips/jz4740/irq.c:69:6: warning: symbol 'jz4740_irq_resume' was not declared. Should it be static? > > Also, I've seen some elusive build errors on my automated build test > where JZ4740_IRQ_BASE and NR_IRQS are missing, but I can't reproduce > them manually for some reason. Anyway, mach-jz4740/irq.h should help us > avoid relying on some implicit include. Patch is looking good. There is a known issue building jz in a separate build directory; building in the source directory itself will succeed. Could that be why you can't seem to reproduce the build issue? Ralf
