On 4 December 2014 at 07:43, Paul Walmsley <paul@xxxxxxxxx> wrote: > Hello Rafał, > > On Fri, 28 Nov 2014, Paul Walmsley wrote: > >> On Thu, 27 Nov 2014, Rafał Miłecki wrote: >> >> > I'm pretty sure you look at some old version of arch/bcm47xx/nvram.c. >> > I wouldn't dare to move such a MIPS-focused driver to some common >> > place ;) >> > >> > Please check for the version of nvram.c in Ralf's upstream-sfr tree. I >> > think you'll like it much more. Hopefully you will even consider it >> > ready for moving to the drivers/firmware/ or whatever :) >> >> OK I will take a look at this, and will either send comments, or will >> send a Reviewed-By:. > > I had the chance to take a brief look at this file, and you are right: I > like your newer version better than the older one :-) > > It is too bad that it seems this flash area has to be accessed very early > in boot. That certainly makes it more difficult to write something > particularly elegant. It is also a pity that it is unknown how to verify > that the flash MMIO window has been configured before reading from these > areas of the address space. But under the circumstances, calling > bcm47xx_nvram_init_from_mem() with the appropriate addresses from the bus > code during early init, as you did, seems rather reasonable. I also like > the code that you added to read the flash data from MTD later in boot. > > Here are a few very minor comments that you are welcome to take or leave > as you wish. Thanks for your comments! I'll address them before (trying) moving driver to the drivers/firmware/. Appreciate your review.
