On 12/2/14 06:01, Carlos O'Donell wrote: > On Mon, Dec 1, 2014 at 4:35 PM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: >> On Mon, Dec 1, 2014 at 9:52 PM, Max Filippov <jcmvbkbc@xxxxxxxxx> wrote: >>> On Mon, Dec 1, 2014 at 11:43 PM, Chen Gang <gang.chen.5i5j@xxxxxxxxx> wrote: >>>> At present, kernel supports madvise(MADV_FREE), so can benefit to all >>>> related architectures (can grep MADV_WILLNEED or MADV_REMOVE in "arch/" >>>> to know about all related architectures). >>> >>> A similar patch has been posted a while ago: >>> >>> http://www.spinics.net/lists/linux-mm/msg81538.html >> OK, thanks. >> Would it be possible to use the same number everywhere? > For current patch, I guess, we can use '8' for it, since MADV_FREE in asm-generic is merged just a few days ago (which is not used by user mode), and parisc has to use '8'. And welcome the related member's ideas. > Yes please. It's ridiculous that we still need patches like this. > > I proposed unifying all this two years ago, but didn't follow up. > > From glibc's perspective it would be simpler if we started using the > same number everywhere. > > http://www.spinics.net/lists/linux-api/msg02064.html > For me, we can divide it into 2 steps: - Let MADV_FREE has the same value (about current patch). - Let all shared MADV_* to "asm-generic" (about next patch, although I am not quite sure whether it is executable). Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed