Hi, On Mon, Nov 24, 2014 at 09:25:26AM -0800, David Daney wrote: > On 11/24/2014 05:51 AM, James Cowgill wrote: > >From: Markos Chandras <markos.chandras@xxxxxxxxxx> > > > >Add support for the UBNT E200 board (EdgeRouter/EdgeRouter Pro 8 port). > > > >Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx> > >Signed-off-by: James Cowgill <James.Cowgill@xxxxxxxxxx> > > NACK. > > As far as I know, these boards have a boot loader that supplies a correct > device tree, there should be no need to hack up the kernel like this. > > As far as I know, Andreas is running a kernel.org kernel on these boards > without anything like this. It gets called from Octeon Ethernet driver through cvmx_helper_link_get() frequently so the console gets spammed about unknown board, and probably also the link status is bogus as a result. I guess all those board helper functions should be factored out and Octeon Ethernet should use DT only. I think we need TODO file under staging/octeon. A.
