On 11/19/2014 07:55 PM, Kevin Cernekee wrote: > On Wed, Nov 19, 2014 at 7:04 PM, Brian Norris > <computersforpeace@xxxxxxxxx> wrote: >> On Sat, Nov 15, 2014 at 04:17:24PM -0800, Kevin Cernekee wrote: >>> The lack of a reboot handler is annoying; syscon-reboot probably won't work >>> on STB (because it requires two writes). >> >> Can't you reuse drivers/power/reset/brcmstb-reboot.c ? > > Oops, I ran a quick check earlier by grepping for "sun-top-ctrl" and > looking under drivers/reset, but assumed this driver wasn't merged yet > when nothing came up in the code. Thanks for the pointer. > > It looks like the current driver will work for 40nm, but 65nm uses > different bit positions: RESET_CTRL bit 3 to arm, and SW_RESET bit 31 > to trigger. I'll add a new "brcm,brcmstb-reboot-65nm" compatible > string to make this work. > > Also, we'll need to take Guenter Roeck's register_restart_handler() > patch in order to build on MIPS. Slightly unrelated, did you also try to use drivers/bus/brcmstb_gisb.c on these MIPS platforms? Its usefulness is probably lower on MIPS since we typically get accurate bus errors to be decoded by the CPU and printed through the exception handler, but I'd be curious if it works just fine as well. Thanks! -- Florian
