On Thu, Nov 13, 2014 at 01:16:19AM +0100, Ralf Baechle wrote: > On Wed, Nov 12, 2014 at 02:41:04PM +0100, Thierry Reding wrote: > > > Hi Ralf, > > > > This commit showed up in linux-next and causes a warning in linux/elf.h > > because it doesn't know struct file. I've fixed it locally with this: > > > > --- > > diff --git a/include/linux/elf.h b/include/linux/elf.h > > index 6bd15043a585..dac5caaa3509 100644 > > --- a/include/linux/elf.h > > +++ b/include/linux/elf.h > > @@ -4,6 +4,8 @@ > > #include <asm/elf.h> > > #include <uapi/linux/elf.h> > > > > +struct file; > > + > > #ifndef elf_read_implies_exec > > /* Executables for which elf_read_implies_exec() returns TRUE will > > have the READ_IMPLIES_EXEC personality flag set automatically. > > --- > > > > Would you mind squashing that into the above commit to get rid of the > > warning? > > To fix the warnings reported by sfr on powerpc64 this morning I moved > most of the code added to <linux/elf.h> into fs/binfmt_elf.c. That > should also have taken care of the warnings you saw for ARM. These changes didn't make it into today's next, but manually applying them I can indeed verify that the build warning is gone. Thierry
Attachment:
pgp2LEtoew7f7.pgp
Description: PGP signature
