On 11/11/2014 16:22, Ralf Baechle wrote: > On Tue, Oct 07, 2014 at 09:17:45PM -0400, Joshua Kinard wrote: > >> cpu_needs_post_dma_flush() in arch/mips/mm/dma-default.c is missing a check for >> CPU_R14000, where it already has checks for CPU_R10000 and CPU_R12000. This >> patch adds the missing CPU_R14000 check. > > Patch is entirely correct. Except. > > This is only used on systems which don't have DMA cache coherency. Those > systems are the IP28 and IP22 which featured an R10000 rsp. R10000 or > R12000 processor which is why the R14000 is intentionally not listed in > this if(). Saves a few bytes and cycles. And probably deserves a > comment in the code! > > Ralf A comment in the code sounds great in that case then! I'll drop this locally, then. Thanks! -- Joshua Kinard Gentoo/MIPS kumba@xxxxxxxxxx 4096R/D25D95E3 2011-03-28 "The past tempts us, the present confuses us, the future frightens us. And our lives slip away, moment by moment, lost in that vast, terrible in-between." --Emperor Turhan, Centauri Republic
