On Tue, Nov 11, 2014 at 02:33:36PM +0100, Boris Brezillon wrote: > First of all IRQCHIP_SKIP_SET_WAKE is not a valid irq_gc_flags and thus > should not be passed as the last argument of > irq_alloc_domain_generic_chips. > > Then pass the correct handler (handle_fasteoi_irq) to > irq_alloc_domain_generic_chips instead of manually re-setting it in the > initialization loop. > > And eventually initialize default irq flags to the pseudo standard: > IRQ_REQUEST | IRQ_PROBE | IRQ_AUTOEN. > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> > --- > Hello Kevin, > > This patch has not been tested yet but it should solve the issue you've > experienced with the IRQ_GC_BE_IO flag and the atmel-aic driver. > > I'll test it tomorrow and let you know if it actually works. > > Regards, > > Boris > > drivers/irqchip/irq-atmel-aic-common.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied to irqchip/urgent with Kevin's Tested-by. Also, flagged for stable, v3.17 and up. Boris, once this is in mainline, you may want to generate a patch against older versions (in the arch dir) for the stable team. thx, Jason.
