On 11/10/2014 04:42 PM, David Daney wrote:
> On 11/10/2014 08:20 AM, Markos Chandras wrote:
>> printk should not be used without a KERN_ facility level
>>
>> Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx>
>> ---
>> arch/mips/kernel/traps.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
>> index 22b19c275044..51fa5c3aa4fe 100644
>> --- a/arch/mips/kernel/traps.c
>> +++ b/arch/mips/kernel/traps.c
>> @@ -1380,12 +1380,12 @@ asmlinkage void do_mcheck(struct pt_regs *regs)
>> show_regs(regs);
>>
>> if (multi_match) {
>> - printk("Index : %0x\n", read_c0_index());
>> - printk("Pagemask: %0x\n", read_c0_pagemask());
>> - printk("EntryHi : %0*lx\n", field, read_c0_entryhi());
>> - printk("EntryLo0: %0*lx\n", field, read_c0_entrylo0());
>> - printk("EntryLo1: %0*lx\n", field, read_c0_entrylo1());
>> - printk("\n");
>> + pr_info("Index : %0x\n", read_c0_index());
>> + pr_info("Pagemask: %0x\n", read_c0_pagemask());
>> + pr_info("EntryHi : %0*lx\n", field, read_c0_entryhi());
>> + pr_info("EntryLo0: %0*lx\n", field, read_c0_entrylo0());
>> + pr_info("EntryLo1: %0*lx\n", field, read_c0_entrylo1());
>> + pr_info("\n");
>
> MachineCheck is a serious problem, If we change this at all, I would
> suggest pr_err() instead.
>
> David Daney
Hi,
Ok I will change all of them to pr_err().
--
markos
