(adding Makefile author Peter Foley onto CC) On Tue, Oct 21, 2014 at 09:58:51AM -0700, David Daney wrote: > On 10/21/2014 09:35 AM, David Miller wrote: > >From: Richard Cochran <richardcochran@xxxxxxxxx> > >Date: Tue, 21 Oct 2014 13:07:25 +0200 > > > >>On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote: > >>>diff --git a/Documentation/ptp/Makefile b/Documentation/ptp/Makefile > >>>index 293d6c09a11f..397c1cd2eda7 100644 > >>>--- a/Documentation/ptp/Makefile > >>>+++ b/Documentation/ptp/Makefile > >>>@@ -1,5 +1,15 @@ > >>> # List of programs to build > >>>+ifndef CROSS_COMPILE > >>> hostprogs-y := testptp > >>>+else > >>>+# MIPS system calls are defined based on the -mabi that is passed > >>>+# to the toolchain which may or may not be a valid option > >>>+# for the host toolchain. So disable testptp if target architecture > >>>+# is MIPS but the host isn't. > >>>+ifndef CONFIG_MIPS > >>>+hostprogs-y := testptp > >>>+endif > >>>+endif > >> > >>It seems like a shame to simply give up and not compile this at all. > >>Is there no way to correctly cross compile this for MIPS? > > > >Yeah seriously, we should try to make this work instead of throwing our > >hands in the air. > > > > We cross compile things successfully all the time for all the > various MIPS ABIs. > > It is a simple matter of having the Makefile setup for cross compiling. > > What I don't understand is why we are using hostprogs in this > Makefile. Isn't this a program that would run on the target, not > the build host? Yes. Peter, could you please fix it? Thanks, Richard
