Re: [PATCH] MIPS: ath79: fix compilation error when CONFIG_PCI is disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/20/2014 02:11 PM, Stefan Hengelein wrote:
> When CONFIG_PCI is disabled, 'db120_pci_init()' had a different
> signature than when was enabled. Therefore, compilation failed when
> CONFIG_PCI was not present.
> 
> arch/mips/ath79/mach-db120.c:132: error: too many arguments to function 'db120_pci_init'
> 
> This error was found with vampyr.
> 
> Signed-off-by: Stefan Hengelein <stefan.hengelein@xxxxxx>
> 
> ---
> Changelog:
> v2: fix prototype instead of removing the caller
> ---
>  arch/mips/ath79/mach-db120.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/ath79/mach-db120.c b/arch/mips/ath79/mach-db120.c
> index 4d661a1..9423f5a 100644
> --- a/arch/mips/ath79/mach-db120.c
> +++ b/arch/mips/ath79/mach-db120.c
> @@ -113,7 +113,7 @@ static void __init db120_pci_init(u8 *eeprom)
>  	ath79_register_pci();
>  }
>  #else
> -static inline void db120_pci_init(void) {}
> +static inline void db120_pci_init(u8 *eeprom) {}
>  #endif /* CONFIG_PCI */
>  
>  static void __init db120_setup(void)
> 
Reviewed-by: Markos Chandras <markos.chandras@xxxxxxxxxx>

-- 
markos





[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux