On Sun, Sep 28, 2014 at 8:33 PM, Sergey Ryazanov <ryazanov.s.a@xxxxxxxxx> wrote: > Atheros AR5312 SoC have a builtin GPIO controller, which could be accessed > via memory mapped registers. This patch adds new driver for them. > > Signed-off-by: Sergey Ryazanov <ryazanov.s.a@xxxxxxxxx> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > Cc: Alexandre Courbot <gnurou@xxxxxxxxx> > Cc: linux-gpio@xxxxxxxxxxxxxxx This driver is extremely simple. You should be able to use drivers/gpio/gpio-generic.c for this. NAK for the time being. > +#define AR5312_GPIO_CR_INT(x) (1 << ((x)+8)) /* mask for interrupt */ Seems to be unused. For a MMIO gpiochip using interrupts it's still possible to use gpio-generic.c as a library- > +#define AR5312_GPIO_CR_UART(x) (1 << ((x)+16)) /* uart multiplex */ That sounds like pin control business. Yours, Linus Walleij
