Re: [PATCH v2] MIPS: Kconfig: Add choice symbol to select microMIPS or SmartMIPS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/21/2014 08:46 AM, Markos Chandras wrote:
> microMIPS and SmartMIPS can't be used together. This fixes the
> following build problem:
> 
> Warning: the 32-bit microMIPS architecture does not support the `smartmips'
> extension
> arch/mips/kernel/entry.S:90: Error: unrecognized opcode `mtlhx $24'
> [...]
> arch/mips/kernel/entry.S:109: Error: unrecognized opcode `mtlhx $24'
> 
> Link: https://dmz-portal.mips.com/bugz/show_bug.cgi?id=1021
> Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx>
> ---
> Hi Ralf,
> 
> Here is v2 of that patch, making SmartMIPS and microMIPS a
> choice symbol as you requested in
> http://www.linux-mips.org/archives/linux-mips/2014-06/msg00011.html
> 
> However, I still feel this is wrong since these two ASEs are completely
> unrelated. The v1 of the patch is probably better in my opinion.
> If the user fails to find the 'smartmips' option due to having 'micromips'
> enabled, he/she can always search for the 'smartmips' symbol in the
> menuconfig and he/she will notice the dependency on !micromips.
> And if the user knows what he is doing he will probably never want to
> use 'smartmips' and 'micromips' together.
> ---
> 
Hi,

Any comments on that one?

-- 
markos





[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux