Re: [PATCH] MIPS: R3000: Fix debug output for Virtual page number

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 10 Sep 2014, Isamu Mogi wrote:

> Virtual page number of R3000 in entryhi is 20 bit from MSB. But in
> dump_tlb(), the bit mask to read it from entryhi is 19 bit (0xffffe000).
> The patch fixes that to 0xfffff000.
> 
> Signed-off-by: Isamu Mogi <isamu@xxxxxxxxxxxx>

Acked-by: Maciej W. Rozycki <macro@xxxxxxxxxxxxxx>

 It would be good to add appropriate macros to <asm/mipsregs.h> too, to 
avoid magic numbers and decrease the likelihood of issues like this.  As a 
separate change, that is, of course, and not a prerequisite.

  Maciej





[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux