Re: [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Pranith Kumar <bobby.prani@xxxxxxxxx>
Subject: Re: [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
From: Jesper Nilsson <jesper.nilsson@xxxxxxxx>
Date: Tue, 23 Sep 2014 17:40:16 +0200
Cc: Richard Henderson <rth@xxxxxxxxxxx>, Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>, Matt Turner <mattst88@xxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Will Deacon <will.deacon@xxxxxxx>, Haavard Skinnemoen <hskinnemoen@xxxxxxxxx>, Hans-Christian Egtvedt <egtvedt@xxxxxxxxxxxx>, Mikael Starvik <starvik@xxxxxxxx>, Jesper Nilsson <jespern@xxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, Hirokazu Takata <takata@xxxxxxxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Ralf Baechle <ralf@xxxxxxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, "maintainer:X86 ARCHITECTURE..." <x86@xxxxxxxxxx>, Chris Zankel <chris@xxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>, Chen Gang <gang.chen@xxxxxxxxxxx>, Victor Kamensky <victor.kamensky@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, "Maciej W. Rozycki" <macro@xxxxxxxxxxxxxxxx>, Sam Ravnborg <sam@xxxxxxxxxxxx>, "open list:ALPHA PORT" <linux-alpha@xxxxxxxxxxxxxxx>, open list <linux-kernel@xxxxxxxxxxxxxxx>, "moderated list:ARM PORT" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, linux-cris-kernel <linux-cris-kernel@xxxxxxxx>, "open list:IA64 (Itanium) PL..." <linux-ia64@xxxxxxxxxxxxxxx>, "moderated list:M32R ARCHITECTURE" <linux-m32r@xxxxxxxxxxxxxxxxxxxxx>, "open list:M32R ARCHITECTURE" <linux-m32r-ja@xxxxxxxxxxxxxxxxxxxxx>, "open list:M68K ARCHITECTURE" <linux-m68k@xxxxxxxxxxxxxxx>, "open list:MIPS" <linux-mips@xxxxxxxxxxxxxx>, "open list:PARISC ARCHITECTURE" <linux-parisc@xxxxxxxxxxxxxxx>, "open list:SUPERH" <linux-sh@xxxxxxxxxxxxxxx>, "open list:SPARC + UltraSPAR..." <sparclinux@xxxxxxxxxxxxxxx>, "open list:TENSILICA XTENSA..." <linux-xtensa@xxxxxxxxxxxxxxxx>, "open list:GENERIC INCLUDE/A..." <linux-arch@xxxxxxxxxxxxxxx>
In-reply-to: <1411482607-20948-1-git-send-email-bobby.prani@gmail.com>
User-agent: Mutt/1.5.20 (2009-06-14)

On Tue, Sep 23, 2014 at 04:29:50PM +0200, Pranith Kumar wrote:
> Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
> is purely a style change.
> 
> Signed-off-by: Pranith Kumar <bobby.prani@xxxxxxxxx>
> ---
>  arch/alpha/include/asm/atomic.h    | 4 ++--
>  arch/arm/include/asm/atomic.h      | 2 +-
>  arch/arm64/include/asm/atomic.h    | 4 ++--
>  arch/avr32/include/asm/atomic.h    | 2 +-
>  arch/cris/include/asm/atomic.h     | 2 +-

For the CRIS parts:

Acked-by: Jesper Nilsson <jesper.nilsson@xxxxxxxx>

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@xxxxxxxx

References:
- [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
  - From: Pranith Kumar

Prev by Date: Re: [RFC][PATCH] sched,mips,ia64: Remove __ARCH_WANT_UNLOCKED_CTXSW
Next by Date: [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs
Previous by thread: Re: [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
Next by thread: Re: [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
Index(es):
- Date
- Thread

[Index of Archives] [Linux MIPS Home] [LKML Archive] [Linux ARM Kernel] [Linux ARM] [Linux] [Git] [Yosemite News] [Linux SCSI] [Linux Hams]