Re: [PATCH] MIPS: Kconfig: Select SMP symbols for CMP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 22, 2014 at 09:29:34AM +0100, Markos Chandras wrote:

> CMP is an SMP implementation, and as a result of which, it needs
> to select the SYS_SUPPORTS_SMP and SMP symbols. This fixes the
> following build problem when CMP is enabled but SMP is not.
> 
> In file included from arch/mips/kernel/smp-cmp.c:34:0:
> ./arch/mips/include/asm/smp.h:26:0: error: "raw_smp_processor_id" redefined
> [-Werror]
>  #define raw_smp_processor_id() (current_thread_info()->cpu)
> [...]
> In file included from arch/mips/kernel/smp-cmp.c:34:0:
> ./arch/mips/include/asm/smp.h:59:20: error: redefinition of
> 'smp_send_reschedule'
> [...]
> ./arch/mips/include/asm/smp.h: In function 'smp_send_reschedule':
> ./arch/mips/include/asm/smp.h:63:8: error: dereferencing pointer to incomplete
> type
> 
> Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx>
> ---
>  arch/mips/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 4e238e6e661c..9e3b67c65a32 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -2026,7 +2026,9 @@ config MIPS_CMP
>  	bool "MIPS CMP framework support (DEPRECATED)"
>  	depends on SYS_SUPPORTS_MIPS_CMP
>  	select MIPS_GIC_IPI
> +	select SMP
>  	select SYNC_R4K
> +	select SYS_SUPPORTS_SMP

It's always a bit inelegant to select a SYMBOL and its prerequisite -
but anyway, applied.

  Ralf


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux