Re: [PATCH] MIPS: IP28: Correct IO_BASE in mach-ip28/spaces.h for proper ioremap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 18, 2014 at 10:55:02PM -0400, Joshua Kinard wrote:

> --- a/arch/mips/include/asm/mach-ip28/spaces.h
> +++ b/arch/mips/include/asm/mach-ip28/spaces.h
> @@ -18,7 +18,7 @@
>  #define PHYS_OFFSET	_AC(0x20000000, UL)
> 
>  #define UNCAC_BASE	_AC(0xc0000000, UL)     /* 0xa0000000 + PHYS_OFFSET */
> -#define IO_BASE		UNCAC_BASE
> +#define IO_BASE		_AC(0x9000000000000000, UL)
> 
>  #include <asm/mach-generic/spaces.h>

I think the real culprit is not the definition of IO_BASE but of
UNCAC_BASE.  0xc0000000UL is KSEG2 for a 32 bit kernel - but for a 64 bit
kernel UNCAC_BASE should be defined as _AC(0x9000000000000000, UL).

Which are the defaults in <asm/mach-generic/spaces.h> so just deleting
both UNCAC_BASE and IO_BASE from mach-ip28/spaces.h should fix things?

  Ralf


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux