Re: [PATCH 1/2] MIPS: MSP71xx: remove unused plat_irq_dispatch() argument

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 14, 2014 at 06:39:17PM +0400, Sergey Ryazanov wrote:

> >> Remove unused argument to make the plat_irq_dispatch() function
> >> declaration similar to the realization of other platforms.
> >
> > The issue may be harmless but the regs argument of the false argument
> > isn't even being passed in!
> >
> IMHO, this argument can't cause smth terrible, until nobody tries to
> access it, but I can mistake.

Correct.

In this particular case it appears that the value passed for regs is
whatever value there was in $a0 in the interrupted code.  Dereferencing
that kind of value would most likely be lethal and crash the kernel
during bootup.

  Ralf


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux