Hi Huacai, On Fri, Aug 01, 2014 at 09:19:11AM +0800, 陈华才 wrote: > Hi, Jayachandran > > I think I introduce a more *general* method of MIPS CPU's topology in commit bda4584cd94 (MIPS: Support CPU topology files in sysfs). So, could you please modify the Netlogic's code to adaptive the new framework? If you can't do that, I'll send a new version of my patch by adding some #ifndef. You have added the definitions for topology in asm/smp.h +#define topology_physical_package_id(cpu) (cpu_data[cpu].package) +#define topology_core_id(cpu) (cpu_data[cpu].core) +#define topology_core_cpumask(cpu) (&cpu_core_map[cpu]) +#define topology_thread_cpumask(cpu) (&cpu_sibling_map[cpu]) These changes have to be in asm/topology.h and should only change the definitions if mach-<platform>/topology.h does not define them. Can you please look at fixing this? Thanks, JC.