Re: [PATCH 3/3] driver:gpio remove all usage of gpio_remove retval in driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Tue, 22 Jul 2014 17:08:13 +0200
Linus Walleij <linus.walleij@xxxxxxxxxx> escreveu:

> On Sat, Jul 12, 2014 at 10:30 PM, abdoulaye berthe <berthe.ab@xxxxxxxxx> wrote:
> 
> Heads up. Requesting ACKs for this patch or I'm atleast warning that it will be
> applied. We're getting rid of the return value from gpiochip_remove().
> 
> > this remove all reference to gpio_remove retval in all driver
> > except pinctrl and gpio. the same thing is done for gpio and
> > pinctrl in two different patches.
> >
> > Signed-off-by: abdoulaye berthe <berthe.ab@xxxxxxxxx>
> (...)
> 
> I think this patch probably needs to be broken down per-subsystem as it
> hits all over the map. But let's start requesting ACKs for the
> individual pieces.
> Actually I think it will be OK to merge because there is likely not much churn
> around these code sites.
> 
> I'm a bit torn between just wanting a big patch for this hitting drivers/gpio
> and smaller patches hitting one subsystem at a time. We should be able
> to hammer this in one switch strike.
> 
...
> >  drivers/media/dvb-frontends/cxd2820r_core.c    | 10 +++-------
> 
> Mauro can you ACK this?

Acked-by: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx>
> 
> (Hm that looks weird. Mental note to look closer at this.)

What's weird there?

Regards,
Mauro


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux