On Sat, Jul 19, 2014 at 07:14:12AM +1000, Dave Airlie wrote: > > > > We have almost 1000 more uses of the non-macro version than the "macro" > > version in the kernel today: > > $ git grep -w DEFINE_PCI_DEVICE_TABLE | wc -l > > 262 > > $ git grep "const struct pci_device_id" | wc -l > > 1254 > > did you check for non-const ones? just to see if we have any of the > broken case in the tree :-) I didn't :) > as for consistency, pci_dev vs usb_device :-P Read farther down the email...