Hi Kees, On 07/17/2014 11:29 PM, Kees Cook wrote: > Hi, > > I recently fixed a bug in seccomp on ARM that I think may be present > in the MIPS implementation too. In arch/mips/kernel/ptrace.c > syscall_trace_enter, the syscall variable is used (and returned), but > the syscall may be changed by either secure_computing or > tracehook_report_syscall_entry (via ptracers which can block and > change the registers). (I would note that "ret" is also set but never > used, so tracehook_report_syscall_entry failures actually won't get > noticed.) > > The discussion about this bug on ARM is here: > https://lkml.org/lkml/2014/6/20/439 Thanks for letting us know. Right, I believe MIPS will have the same problem and a similar patch to Will Deacon's one will fix it properly. Would you like to submit one for MIPS too? Otherwise I can do it myself. > > I don't yet have a working MIPS environment to test this on, but it > feels like the same bug. (Though, for testing, what's the right way to > change syscall during PTRACE_SYSCALL? On x86 it's the orig_ax > register, on ARM it's a arch-specific ptrace function > (PTRACE_SET_SYSCALL). For MIPS, the syscall numbers is in the v0 register ($2). But the o32 ABI also has the syscall() system call. So in case of indirect system calls, the real system call is the first argument of syscall(), which is register a0 ($4). See syscall_get_nr in arch/mips/include/asm/syscall.h -- markos
