On 07/17/2014 02:58 PM, Andrey Utkin wrote: > 2014-07-17 16:52 GMT+03:00 Markos Chandras <Markos.Chandras@xxxxxxxxxx>: >> Thanks for the patch. I would personally prefer to use a new signed int >> variable, but I am fine either way. > > If that's not a problem for performance etc., then i'll resubmit with > new temporary signed variable, because i believe it would be simpler > to comprehend. > Hi Andrey, Well, this function is executed during the filter compilation so it's only executed once (or maybe a few times) per filter (assuming the filter uses the SKF_AD_PKTTYPE opcode at all) so performance is not really critical at this point. The performance become a critical factor for the execution of the jitted filter. But yes, avoiding passing the argument and doing the pointer operation later on could save some instructions which is both good for compilation performance and also makes the function simpler as you said. -- markos
