On Mon, Jul 14, 2014 at 12:04 PM, Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote: > On Fri, Jul 11, 2014 at 10:55 AM, Kees Cook <keescook@xxxxxxxxxxxx> wrote: >> On Fri, Jul 11, 2014 at 9:49 AM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote: >>> On 07/10, Kees Cook wrote: >>>> >>>> This adds the ability for threads to request seccomp filter >>>> synchronization across their thread group (at filter attach time). >>>> For example, for Chrome to make sure graphic driver threads are fully >>>> confined after seccomp filters have been attached. >>>> >>>> To support this, locking on seccomp changes via thread-group-shared >>>> sighand lock is introduced, along with refactoring of no_new_privs. Races >>>> with thread creation are handled via delayed duplication of the seccomp >>>> task struct field and cred_guard_mutex. >>>> >>>> This includes a new syscall (instead of adding a new prctl option), >>>> as suggested by Andy Lutomirski and Michael Kerrisk. >>> >>> I do not not see any problems in this version, >> >> Awesome! Thank you for all the reviews. :) If Andy and Michael are >> happy with this too, I think this is in good shape. \o/ > > I think I'm happy with it. Is it in git somewhere for easy perusal? > I have a cold, so my reviewing ability is a bit off, but I want to > take a look at the final version, and git is a little easier than > email for this. Yes, absolutely: https://git.kernel.org/cgit/linux/kernel/git/kees/linux.git/log/?h=seccomp-tsync Thanks for looking it over, and I hope you feel better soon! -Kees -- Kees Cook Chrome OS Security
