On Sun, 6 Jul 2014, Jonas Gorski wrote: > On Sun, Jul 6, 2014 at 1:23 AM, Emil Goode <emilgoode@xxxxxxxxx> wrote: > > We check that the struct vm_area_struct pointer vma is NULL and then > > dereference it a few lines below. The intent was to make sure vma is > > not NULL but this is not necessary since the bug pre-dates GIT history > > and seem to never have caused a problem. The tlb-4k and tlb-8k versions > > of local_flush_tlb_page() don't bother checking if vma is NULL, also > > vma is dereferenced before being passed to local_flush_tlb_page(), > > thus it is safe to remove this NULL check. > > > > Signed-off-by: Emil Goode <emilgoode@xxxxxxxxx> > > Looks good. > > Reviewed-by: Jonas Gorski <jogo@xxxxxxxxxxx> Acked-by: Maciej W. Rozycki <macro@xxxxxxxxxxxxxx> (as per the observations at the previous version). Maciej
