Hi Mike, On Wed, Jul 2, 2014 at 7:20 AM, Mike Turquette <mturquette@xxxxxxxxxx> wrote: > Quoting Manuel Lauss (2014-06-29 09:57:35) >> Expose chip-internal configurable clocks to the common clk framework, >> and fix a few drivers to take advantage of it. > > Thanks for the patch series! Both patches cover a lot of ground, but > I'll focus on #2. It would be best to split the driver changes out I sent the first one along because the second doesn't compile without it. > separately. You can introduce the common clk changes but not compile > them in, then change the drivers, then add the logic to compile the new > common clock driver all as separate patches. I'll split them into pure clock framework and enablement parts. > Additionally, it would be cool to push this driver out to drivers/clk/ > if you are so inclined. It looks like your header dependencies are not > so bad as to make that task impossible. Just a suggestion from me. This clock framework is for a single line of MIPS SoCs which are no longer being developed by the manufacturer and I don't think it is reusable for any other soc line currently in existence. I'd like to keep it within the mips tree for that reason. (I find the ARM way of sprinkling the whole tree with a single driver for each iteration of each custom on-chip peripheral on each ARM chip [exaggerated of course] quite messy. But that's just me). Manuel
