Re: [PATCH 1/1] MIPS: jz4740: remove unnecessary null test before debugfs_remove

[Lars-Peter Clausen <lars@xxxxxxxxxx>]

On 06/29/2014 09:24 AM, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: debugfs_remove(NULL) is safe this check is probably not required
>
> Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> Cc: linux-mips@xxxxxxxxxxxxxx
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>

Acked-by: Lars-Peter Clausen <lars@xxxxxxxxxx>

Thanks.

> ---
>   arch/mips/jz4740/clock-debugfs.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/mips/jz4740/clock-debugfs.c b/arch/mips/jz4740/clock-debugfs.c
> index a8acdef..325422d0 100644
> --- a/arch/mips/jz4740/clock-debugfs.c
> +++ b/arch/mips/jz4740/clock-debugfs.c
> @@ -87,8 +87,7 @@ void jz4740_clock_debugfs_add_clk(struct clk *clk)
>   /* TODO: Locking */
>   void jz4740_clock_debugfs_update_parent(struct clk *clk)
>   {
> -	if (clk->debugfs_parent_entry)
> -		debugfs_remove(clk->debugfs_parent_entry);
> +	debugfs_remove(clk->debugfs_parent_entry);
>
>   	if (clk->parent) {
>   		char parent_path[100];