On 06/23/2014 11:09 PM, Alexei Starovoitov wrote: > On Mon, Jun 23, 2014 at 2:38 AM, Markos Chandras > <markos.chandras@xxxxxxxxxx> wrote: >> Previously, the negative offset was not checked leading to failures >> due to trying to load data beyond the skb struct boundaries. Until we >> have proper asm helpers in place, it's best if we return ENOSUPP if K >> is negative when trying to JIT the filter or 0 during runtime if we >> do an indirect load where the value of X is unknown during build time. >> >> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> >> Cc: Daniel Borkmann <dborkman@xxxxxxxxxx> >> Cc: Alexei Starovoitov <ast@xxxxxxxxxxxx> >> Cc: netdev@xxxxxxxxxxxxxxx >> Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx> > > Hi Markos, > > thank you for addressing all of my earlier comments. > Looks like test_bpf was quite useful in finding all of these bugs :) > For the patches that reached netdev: > > Acked-by: Alexei Starovoitov <ast@xxxxxxxxxxxx> > Thank you for the review and your constructive comments in your previous emails. -- markos
