On 20/06/14 11:40, Sorin Dumitru wrote: > On 06/20/14 12:54, James Hogan wrote: >> On 20/06/14 08:53, Sorin Dumitru wrote: >>> Signed-off-by: Sorin Dumitru <sdumitru@xxxxxxxxxxx> >> >> A little more commit message wouldn't hurt. Did it break a particular >> program? > > Yes, it was found by an internal program trying to get IP_PKTOPTIONS on > a cavium octeon board. > > Should I resubmit stating what was broken in the commit message? Yeh, if you don't mind. I think it's useful to know exactly why a change was made and what it fixes when later digging through the git history (e.g. commit 515c7af85ed9 is a great example of that). Thanks James
