Re: [PATCH 1/3] MIPS: OCTEON: SMP: delete redundant check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/16/2014 01:06 PM, Aaro Koskinen wrote:
The same check is already done earlier in octeon_smp_hotplug_setup().

Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx>

This seems fine, we want to move away from panicking the kernel towards runtime detection of capabilities. This is certainly no worse in that regard.

Acked-by: David Daney <david.daney@xxxxxxxxxx>


---
  arch/mips/cavium-octeon/smp.c | 8 --------
  1 file changed, 8 deletions(-)

diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
index a7b3ae1..2c8d156 100644
--- a/arch/mips/cavium-octeon/smp.c
+++ b/arch/mips/cavium-octeon/smp.c
@@ -192,14 +192,6 @@ static void octeon_init_secondary(void)
   */
  void octeon_prepare_cpus(unsigned int max_cpus)
  {
-#ifdef CONFIG_HOTPLUG_CPU
-	struct linux_app_boot_info *labi;
-
-	labi = (struct linux_app_boot_info *)PHYS_TO_XKSEG_CACHED(LABI_ADDR_IN_BOOTLOADER);
-
-	if (labi->labi_signature != LABI_SIGNATURE)
-		panic("The bootloader version on this board is incorrect.");
-#endif
  	/*
  	 * Only the low order mailbox bits are used for IPIs, leave
  	 * the other bits alone.




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux