On 06/17/2014 11:16 AM, Daniel Borkmann wrote: > On 06/17/2014 10:20 AM, Daniel Borkmann wrote: >> On 06/17/2014 04:24 AM, Guenter Roeck wrote: >>> mips:allmodconfig fails in 3.16-rc1 with lots of undefined symbols. >>> >>> arch/mips/net/bpf_jit.c: In function 'is_load_to_a': >>> arch/mips/net/bpf_jit.c:559:7: error: 'BPF_S_LD_W_LEN' undeclared >>> (first use in this function) >>> arch/mips/net/bpf_jit.c:559:7: note: each undeclared identifier is >>> reported only once for each function it appears in >>> arch/mips/net/bpf_jit.c:560:7: error: 'BPF_S_LD_W_ABS' undeclared >>> (first use in this function) >>> arch/mips/net/bpf_jit.c:561:7: error: 'BPF_S_LD_H_ABS' undeclared >>> (first use in this function) >>> arch/mips/net/bpf_jit.c:562:7: error: 'BPF_S_LD_B_ABS' undeclared >>> (first use in this function) >>> arch/mips/net/bpf_jit.c:563:7: error: 'BPF_S_ANC_CPU' undeclared >>> (first use in this function) >>> arch/mips/net/bpf_jit.c:564:7: error: 'BPF_S_ANC_IFINDEX' undeclared >>> (first use in this function) >>> arch/mips/net/bpf_jit.c:565:7: error: 'BPF_S_ANC_MARK' undeclared >>> (first use in this function) >>> >>> and so on. >>> >>> Those symbols are not defined anywhere. >>> >>> The problem is due to a conflict with commit 348059313 (net: filter: >>> get rid of BPF_S_* >>> enum), which removed those definitions. >> >> Yep, it seems both got in this merge window from different trees. >> Don't have mips, but >> I'll have a look, and send you a patch. > > Could you give the attached patch a try? > > Thanks, > > Daniel Hi Daniel, This fixes the build and seems to work ok (tried with dhcp and tcpdump). Thanks for fixing it. Reviewed-by: Markos Chandras <markos.chandras@xxxxxxxxxx> Tested-by: Markos Chandras <markos.chandras@xxxxxxxxxx> -- markos