On Tue, 3 Jun 2014, Ralf Baechle wrote: > > Warning: the 32-bit microMIPS architecture does not support the `smartmips' > > extension > > arch/mips/kernel/entry.S:90: Error: unrecognized opcode `mtlhx $24' > > [...] > > arch/mips/kernel/entry.S:109: Error: unrecognized opcode `mtlhx $24' > > > > Link: https://dmz-portal.mips.com/bugz/show_bug.cgi?id=1021 > > Reviewed-by: Steven J. Hill <Steven.Hill@xxxxxxxxxx> > > Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx> > > --- > > arch/mips/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > > index 2fe8e60..ffde3d6 100644 > > --- a/arch/mips/Kconfig > > +++ b/arch/mips/Kconfig > > @@ -2063,7 +2063,7 @@ config ARCH_PHYS_ADDR_T_64BIT > > def_bool 64BIT_PHYS_ADDR > > > > config CPU_HAS_SMARTMIPS > > - depends on SYS_SUPPORTS_SMARTMIPS > > + depends on SYS_SUPPORTS_SMARTMIPS && !CPU_MICROMIPS > > bool "Support for the SmartMIPS ASE" > > help > > SmartMIPS is a extension of the MIPS32 architecture aimed at > > >From a user's perspective that's a bit quirky; a user has to first > disable CPU_MICROMIPS before he can enable CPU_HAS_SMARTMIPS. So I > think this should become a choice statement. Do we need this CPU_HAS_SMARTMIPS setting at all? Can't we just save/restore this SmartMIPS ACX register on context switches where available (straightforward to detect at the run time) and have the relevant pieces of code excluded (#ifdef-ed out or suchlike) on non-supported configurations such as microMIPS or MIPS64? Maciej
