On Thu, May 22, 2014 at 03:26:45PM +0200, Ralf Baechle wrote:
> On Tue, May 20, 2014 at 06:16:14PM +0200, Paul Bolle wrote:
>
> > Three checks for CONFIG_CAVIUM_GDB were added in v2.6.29. But the
> > Kconfig symbol CAVIUM_GDB was never added to the tree. Remove these
> > checks.
> >
> > Also remove the last reference to octeon_get_boot_debug_flag(). There is
> > no definition of that function anyway.
> >
> > Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
>
> Queued for 3.16. Thanks Paul & Andreas!
>
> > A follow up might be to remove plat_smp_ops.cpus_done. All these
> > callbacks are now (basically) nops.
>
> I'll think about it. The hook is no useful if unused then again now and
> then ordering issues in SMP startup of secondary CPUs are showing up and
> it may be useful to solve those. Maybe something like
>
> void __init smp_cpus_done(unsigned int max_cpus)
> {
> - mp_ops->cpus_done();
> + if (cpus_done)
> + mp_ops->cpus_done();
> }
>
> which would make a NULL cpus_done function pointer safe and allow empty definitions
> to be removed.
I'd prefer this solution over complete removal of the hook.
Andreas
